Skip to content

add task solution - #1921

Open
oleshna27l-debug wants to merge 2 commits into
mate-academy:masterfrom
oleshna27l-debug:develop
Open

oleshna27l-debug wants to merge 2 commits into
mate-academy:masterfrom
oleshna27l-debug:develop

Conversation

@oleshna27l-debug

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The row-generation logic correctly creates six cells, calculates age and century, and appends rows to the dashboard. However, src/scripts/main.js uses a hardcoded people array instead of importing the required data from people.json, so the rows are not generated from the specified source. The changes also include src/styles/main.scss, despite the task restricting edits to main.js; remove the stylesheet change to meet that scope requirement. The PR description should also provide the required personalized GitHub Pages demo link rather than only a repository URL. These changes will bring the submission in line with the stated requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example ↩

  2. Re-request AI review example ↩

  3. Add AI review comments example ↩

Comment thread src/scripts/main.js
const table = document.querySelector('.dashboard');

// write your code here
people.forEach((person) => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This iterates the locally hardcoded people array rather than the array imported from people.json, as the task specifies. Use the provided imported data so the rows are generated from the source file.

Comment thread src/styles/main.scss
display: flex;
justify-content: center;
align-items: center;
justify-content: center;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires changing only main.js and explicitly says not to change styles. This stylesheet does not implement the table generation; submit the required changes in main.js instead.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The row-generation logic meets the core requirements, but two blockers remain. Revert the change to src/styles/main.scss; the task permits changes only to main.js. Also, the static import at src/scripts/main.js:3 fails to bundle because src/index.html:26 loads the file as a classic script; adjust the loading approach in main.js so the build succeeds without expanding the task’s allowed scope. Once these are addressed, the implementation should be ready for approval.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example ↩

  2. Re-request AI review example ↩

  3. Add AI review comments example ↩

Comment thread src/styles/main.scss
display: flex;
justify-content: center;
align-items: center;
justify-content: center;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stylesheet is outside the task’s allowed scope, which requires changing only main.js. Revert the changes to src/styles/main.scss and keep the styling unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants