Repository navigation
Solution - #1920
Solution#1920Patryk91sz wants to merge 2 commits into
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution has a critical functional error that violates the task requirements. The task explicitly requires finding a table with class dashboard, but line 118 uses document.querySelector('table') which selects any table element. This will fail if there's more than one table on the page or if the table doesn't have the expected structure.
Required fix: Change document.querySelector('table') to document.querySelector('.dashboard') to match the task requirement.
The rest of your implementation is correct - the data processing, age calculation (person.died - person.born), century calculation (Math.ceil(person.died / 100)), and row creation with all 6 cells work properly. Once you fix the selector, the solution will be complete.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| console.log(people); // you can remove it | ||
|
|
||
| // write your code here | ||
| const tabela = document.querySelector('table'); |
There was a problem hiding this comment.
The task requires finding a table with class 'dashboard', but this selects any table. Use document.querySelector('.dashboard') instead.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your solution is approved. The implementation now correctly meets all task requirements — the critical issue has been resolved with line 360 now properly using document.querySelector('.dashboard') to select the table element. All six required columns (name, gender, born, died, age, century) are correctly generated with proper calculations: age as person.died - person.born and century as Math.ceil(person.died / 100). The rows are properly appended to the dashboard table. No changes needed.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
No description provided.