Skip to content

Develop - #1919

Open
serg121192 wants to merge 2 commits into
mate-academy:masterfrom
serg121192:develop
Open

Develop#1919
serg121192 wants to merge 2 commits into
mate-academy:masterfrom
serg121192:develop

Conversation

@serg121192

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation in src/scripts/main.js correctly fulfills all task requirements. The code successfully finds the table with class dashboard, iterates through the people array, and creates table rows with all 6 required cells (name, gender converted from 'f'/'m' to 'Female'/'Male', born, died, age calculated as person.died - person.born, and century calculated as Math.ceil(person.died / 100)). The src/styles/main.scss file is correctly left unchanged as specified in the task. All calculations match the formulas provided in the task description, and no issues were found that would prevent the code from working as intended.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example ↩

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants