Skip to content

solution - #1912

Open
smialeknicole wants to merge 1 commit into
mate-academy:masterfrom
smialeknicole:develop
Open

smialeknicole wants to merge 1 commit into
mate-academy:masterfrom
smialeknicole:develop

Conversation

@smialeknicole

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved and meets all task requirements. The code correctly generates table rows from the people array with all 6 required cells (name, gender, born, died, age, century), calculates age as died - born, calculates century using Math.ceil(died / 100), finds the dashboard table with document.querySelector('.dashboard'), and appends the rows. The gender conversion from 'm'/'f' to 'Male'/'Female' is also working correctly. The only minor improvement would be renaming the variable Nazwy (Polish for "names") to an English name like rowData or cells for better code clarity, but this is a cosmetic issue that doesn't affect functionality.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants