Skip to content

solution v0.1 - #1909

Open
Delviiiii wants to merge 1 commit into
mate-academy:masterfrom
Delviiiii:develop
Open

Delviiiii wants to merge 1 commit into
mate-academy:masterfrom
Delviiiii:develop

Conversation

@Delviiiii

Copy link
Copy Markdown
- [DEMO LINK](https://Delviiiii.github.io/js_task_generate_table_DOM/)

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation successfully meets all core requirements for the table dashboard task. The code correctly imports the people.json array, creates table rows with all 6 required cells (name, gender, born, died, age, century), and properly calculates derived values: age using person.died - person.born and century using Math.ceil(person.died / 100). The rows are correctly appended to the table element with class 'dashboard'. No critical issues were identified - the functionality is complete and working as expected.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants