Repository navigation
add task solution - #1972
add task solution#1972krivchenkov321-Serhii wants to merge 2 commits into
Conversation
krivchenkov321-Serhii
commented
Oct 25, 2026
krivchenkov321-Serhii
commented
- DEMO LINK
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation has two critical issues that violate explicit task requirements. First, the placeholder text is not capitalized as required by the task description - you need to use a method like el.name.charAt(0).toUpperCase() + el.name.slice(1) to capitalize the first letter of the placeholder. Second, you're selecting inputs from the entire document with document.querySelectorAll('input') instead of getting them from the form element as specified in the requirements. Please fix both of these issues to meet the task specifications.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| el.parentElement.append(label); | ||
| }); | ||
|
|
||
| inputs.forEach((el) => el.setAttribute('placeholder', el.name)); |
There was a problem hiding this comment.
The placeholder text is not capitalized. The task requires 'Set placeholder text based on input name, capitalized'. Use a method like el.name.charAt(0).toUpperCase() + el.name.slice(1) to capitalize the first letter.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your code still has one critical blocker that must be fixed. You're using document.querySelectorAll('input') which selects all inputs from the entire document. The task explicitly requires getting inputs from the form element specifically: "Get all inputs from form tag on the page" using form.querySelectorAll('input').
To fix this, first select the form element (e.g., const form = document.querySelector('form')), then use form.querySelectorAll('input') to get only the inputs within that form. This is a core requirement that must be implemented correctly for the task to be considered complete.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| 'use strict'; | ||
|
|
||
| // write code here | ||
| const inputs = [...document.querySelectorAll('input')]; |
There was a problem hiding this comment.
Select inputs from the form element instead of the entire document. Use document.querySelector('form').querySelectorAll('input') or get the form element first, then query its inputs.
