Skip to content

solution v0.1 - #1971

Open
Delviiiii wants to merge 1 commit into
mate-academy:masterfrom
Delviiiii:develop
Open

Delviiiii wants to merge 1 commit into
mate-academy:masterfrom
Delviiiii:develop

Conversation

@Delviiiii

Copy link
Copy Markdown
- [DEMO LINK](https://Delviiiii.github.io/js_task_fix_form_DOM/)

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation is functionally correct and successfully meets all the core requirements. Labels are created with proper for attributes, placeholders are set and capitalized using the name attribute, and inputs are modified as expected. The code produces the correct visual result.

Minor note: You used document.querySelectorAll('input.field-text') instead of selecting inputs from a form element as specified in the task (Step 1). While your approach works in practice, the task explicitly requires using a form element as the starting point. Consider changing to document.querySelectorAll('form input') or selecting the form first and then querying its inputs to align with the stated requirements.

Overall, this is good work and accomplishes the task goals effectively.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example ↩

Comment thread src/scripts/main.js
'use strict';

// write code here
const inputs = [...document.querySelectorAll('input.field-text')];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task requires getting inputs FROM the form tag (Step 1), but this selector only looks for inputs with class field-text anywhere on the page. Use document.querySelectorAll('form input') or select the form first, then query its inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants