Repository navigation
Develop - #1940
Develop#1940Patryk91sz wants to merge 5 commits into
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation in src/scripts/main.js is correct and meets all task requirements. The pushNotification function properly creates notification elements with the correct structure (div with notification + type class, h2 title, p description), positions them at the specified coordinates, and uses setTimeout with display: none to hide them after 2 seconds.
The test failures you see are due to a test specification issue, not your code. The Cypress tests expect an exact CSS string match for top and right properties, but your implementation correctly includes position: absolute as well (which is proper practice). The passing test ("messages should disappear in 2 seconds") confirms your core functionality works correctly.
All requirements from the checklist are satisfied - no changes needed to your implementation.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The implementation is missing a critical style property. The notifications need position: absolute to be properly positioned at the specified coordinates. Currently, setting top and right styles without the position property won't actually place the notification at the requested location—CSS requires position: absolute (or fixed/relative) for top/right coordinates to take effect.
Add notificationDiv.style.position = 'absolute' after setting the top/right styles in the pushNotification function. This is needed for the core functionality of positioning notifications at the specified coordinates to work correctly.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| notificationDiv.style.top = `${posTop}px`; | ||
| notificationDiv.style.right = `${posRight}px`; |
There was a problem hiding this comment.
The notifications need position: absolute style to be properly positioned at the specified coordinates. Add notificationDiv.style.position = 'absolute' after setting top/right styles.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
The next review attempt will not launch automatically.
Push a commit with your changes to this pull request, or write a comment that mentions me.
Then request a new review with the Re-request review button next to my name in the Reviewers section.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
The next review attempt will not launch automatically.
Push a commit with your changes to this pull request, or write a comment that mentions me.
Then request a new review with the Re-request review button next to my name in the Reviewers section.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Sorry, the pull request review was unsuccessful for the following reasons:
Warning
No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]
The next review attempt will not launch automatically.
Push a commit with your changes to this pull request, or write a comment that mentions me.
Then request a new review with the Re-request review button next to my name in the Reviewers section.
If you believe this is an error or need assistance, please contact the support team.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation correctly creates success, error, and warning notifications with the required title and description, positions them using the supplied coordinates, and hides them after two seconds without removing them from the DOM. The reviewed source includes position: absolute, addressing the issue noted in the Cypress check-run report; that report still records failures for the three notification-style tests, so the test result does not reflect the corrected source shown in this review. This is an educational approval to help you progress while learning, with the check-run discrepancy noted for awareness. Lint and formatting passed, and the delayed-hiding test passed.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
No description provided.