Repository navigation
Conversation
zibi-dev
suggested changes
Oct 26, 2026
| @@ -9,4 +9,4 @@ | |||
|
|
|||
| it(`should return an array`, () => {}); | |||
There was a problem hiding this comment.
ten test should return an array jest tu ciagle pusty, wiec zawsze przechodzi i nic nie sprawdza
|
|
||
| it(`should return an array`, () => {}); | ||
|
|
||
| it(`should return an empty string |
There was a problem hiding this comment.
nazwa testu mowi o pustym stringu, a w srodku sprawdzasz ['Mate', 'Academy']. nazwa i kod musza sie zgadzac. albo zmien opis na cos w stylu should reverse words and keep their lengths, albo zrob tu faktycznie przypadek z [''] i oczekiwanie [''].
There was a problem hiding this comment.
twoje 2 nowe testy sa dobre, ale wszystkie 3 przypadki to tablice z wieloma slowami. brakuje jednego slowa, np. ['Hell0'] -> ['0lleH'] z readme, oraz przypadku z pustym stringiem. bez nich zla implementacja moze dalej przechodzic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.