Repository navigation
Add tests for arrayReverse function - #203
oberezhnay wants to merge 3 commits into
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
I am requesting changes because one test expectation contradicts the task requirement and will block correct implementations. Specifically, in src/arrayReverse.test.js around lines 24–26, the test expects arrayReverse(['Mate', 'Academy']) to equal ['ymed', 'aceteM'], but the task description specifies the correct result should be ['ymed', 'acAetaM']. This mismatch is a critical blocker: even a correct solution will fail the tests. Please update the expected value to ['ymed', 'acAetaM'] on that test. The rest of the tests appear appropriate and helpful. As a minor improvement, consider adding a clearer description for multi-element reversal and possibly an additional case to demonstrate varied string lengths. Keep up the good work—once this expectation is fixed, the suite should accurately validate the intended behavior.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your test file correctly implements all requirements from the task description. The test expectations are accurate: the arrayReverse function is properly named, accepts array parameters, reverses each string's characters individually (['Hell0'] → ['0lleH']), and reverses both the string characters and array order (['Mate', 'Academy'] → ['ymed', 'acAetaM']). The critical blocker from the previous review has been resolved, and all Jest assertions use toEqual as expected. No issues remain.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Tests for arrayReverse function