Skip to content

test: add array reverse coverage - #201

Open
AndrzejFront wants to merge 2 commits into
mate-academy:mainfrom
AndrzejFront:develop
Open

AndrzejFront wants to merge 2 commits into
mate-academy:mainfrom
AndrzejFront:develop

Conversation

@AndrzejFront

Copy link
Copy Markdown

No description provided.

Comment thread src/arrayReverse.test.js Outdated
expect(arrayReverse(['Hell0'])).toEqual(['0lleH']);
});

it(`should reverse all characters and keep the original string lengths`, () => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeden test robi dwa różne sprawdzenia naraz, Lepiej by to wyglądało jako dwa osobne testy, jakby coś nie wyszło, od razu wiadomo który konkretnie przypadek się wywalił, zamiast szukać w jednym bloku.

@zibi-dev zibi-dev left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testy pokrywają README, CI przechodzi, a poprzednia uwaga została poprawiona.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants