docs: resolve D-2 - multi-material merge stays out of wave.js - #210
Closed
timurbazhirov wants to merge 1 commit into
Closed
Conversation
Rather than (a) a materials[] prop on ThreeDEditor or (b) a new merge-workflow component in this repo, the multi-material merge workflow belongs in materials-designer, built on wave.js's existing single-material ThreeDEditor plus this session's group-transform primitives (select/drag/rotate a rigid group of atoms). Updates the spec's decision table (§9), props table (§6.2), and roadmap (§11), plus the plan doc's outstanding-decisions table, so nothing still reads D-2 as open or as a wave.js roadmap item. Notes two integration shapes for materials-designer, neither needing wave.js changes today: pre-merging materials into one before handing ThreeDEditor a single material as usual, or building a custom viewer against lower-level primitives (Wave, createAtomsGroup, getUnitCellObject) - which would need those exported from src/exports.js, deferred until actually needed rather than grown speculatively. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 13, 2026
Member
Author
|
Closing — consolidated into #216 (then #214 on top). Verified contained: this PR's head D-2's reasoning got reused, incidentally: the same "where does wave.js stop and the host app begin" question was the one holding U-12 and U-13, and each answered it in its own §0.1 entry — figure export needs renderer internals a host cannot reach, so it stays here; the file handoff stays with the host. The branch Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
materials[]prop onThreeDEditoror a new merge-workflow component in this repo, the merge workflow belongs in materials-designer — built on wave.js's existing single-materialThreeDEditorplus this session's group-transform primitives (select/drag/rotate a rigid group of atoms as one unit).materialprop's notes (§6.2), the roadmap table (§11), and the plan doc's outstanding-decisions table + shipped-so-far summary.ThreeDEditora single material as usual, or build a custom viewer against lower-level primitives (Wave,createAtomsGroup,getUnitCellObject) — which would need those exported fromsrc/exports.js, deliberately deferred until MD actually needs that path rather than growing the public API speculatively.Test plan
npm test/tsc/lint/buildunaffected.D-2reference after editing to confirm nothing still reads it as open.🤖 Generated with Claude Code