SOF-7926: adapt wave.js to made getBasis/getLattice API (SOF-7926) - #202
Merged
Conversation
Pin @mat3ra/made and @mat3ra/code to git archive tarballs from the constraints refactor branch and replace removed Material.Basis/Lattice accessors with getBasis()/getLattice(). Co-authored-by: Cursor <cursoragent@cursor.com>
| oid sha256:3b6350bd9576ef522c2b879db2eceff36c7ce43b4d13ba5a1425713b74850f21 | ||
| size 769 | ||
| oid sha256:7ad56cab981da286f4ee754a851ce520c89aabcb0cb7912b9cdfc81db0a11074 | ||
| size 817 |
Member
There was a problem hiding this comment.
We shouldn't require hash to do the visualization
timurbazhirov
approved these changes
Aug 3, 2026
❌ Deploy Preview for mat3ra-mave failed. Why did it fail? →
|
Material.clone()/toJSON now resolve material-enhanced-hashed via JSONSchemasInterface; register schemas.json in tests so CI does not fail. Co-authored-by: Cursor <cursoragent@cursor.com>
@mat3ra/code deepClone uses structuredClone, which Jest 27 jsdom does not provide. Co-authored-by: Cursor <cursoragent@cursor.com>
timurbazhirov
pushed a commit
that referenced
this pull request
Aug 14, 2026
…e API #202 (SOF-7926) landed on dev while this was open, removing the `Material.Basis` and `Material.Lattice` accessors in favour of `getBasis()` / `getLattice()` and `setLattice()`, and bumping code/esse/made to 2026.8.13-0. That commit adapted the four call sites that existed on dev. This branch carries the interactive-editor stack, which dev has never seen, so it had eleven more — in `ThreeDEditor`, `interactive_structure_editor` and `StatusBar` — plus ten in tests. All migrated. `Made.Basis` / `Made.Lattice` are static references on the namespace and are deliberately untouched. `StatusBar`'s `MaterialLike` gains `getLattice?: () => LatticeLike` in place of the `Lattice` property. Its fixtures are deliberately plain objects rather than real Materials, so they now expose the accessor as a function; a test was added for a material carrying no accessor at all, which must return "" rather than throw. Two conflicts resolved in this branch's favour, both against changes #202 made to code the editor stack had already deleted: - `materialsToThreeDSceneData` in `src/utils.js`. Removed in `7beb8ae` because it built an entire WebGL `Wave` just to serialize scene JSON, was never exported from `exports.js`, had no caller, and was the only edge in the utils <-> wave import cycle. #202 only adapted its accessors; the deletion stands. - `onThreejsEditorModalHide` in `ThreeDEditor`. Dead since the editor moved in-viewer. Verified: lint 0 errors, `tsc --noEmit` clean, 431 tests passing across 30 suites, production build clean.
timurbazhirov
pushed a commit
that referenced
this pull request
Aug 14, 2026
…e API #202 (SOF-7926) landed on dev while this was open, removing the `Material.Basis` and `Material.Lattice` accessors in favour of `getBasis()` / `getLattice()` and `setLattice()`, and bumping code/esse/made to 2026.8.13-0. That commit adapted the four call sites that existed on dev. This branch carries the interactive-editor stack, which dev has never seen, so it had eleven more — in `ThreeDEditor`, `interactive_structure_editor` and `StatusBar` — plus ten in tests. All migrated. `Made.Basis` / `Made.Lattice` are static references on the namespace and are deliberately untouched. `StatusBar`'s `MaterialLike` gains `getLattice?: () => LatticeLike` in place of the `Lattice` property. Its fixtures are deliberately plain objects rather than real Materials, so they now expose the accessor as a function; a test was added for a material carrying no accessor at all, which must return "" rather than throw. Two conflicts resolved in this branch's favour, both against changes #202 made to code the editor stack had already deleted: - `materialsToThreeDSceneData` in `src/utils.js`. Removed in `7beb8ae` because it built an entire WebGL `Wave` just to serialize scene JSON, was never exported from `exports.js`, had no caller, and was the only edge in the utils <-> wave import cycle. #202 only adapted its accessors; the deletion stands. - `onThreejsEditorModalHide` in `ThreeDEditor`. Dead since the editor moved in-viewer. Verified: lint 0 errors, `tsc --noEmit` clean, 461 tests passing across 32 suites, production build clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin @mat3ra/made and @mat3ra/code to git archive tarballs from the constraints refactor branch and replace removed Material.Basis/Lattice accessors with getBasis()/getLattice().