cs: the fusion-consequence comment names its whole class; reserved cites SPEC §4.3 (#213) - #230
Merged
Merged
Conversation
…d refusal cites SPEC §4.3 — closes #213 From the #208 review (finding §4 + the §10 nit): the consequence bullet named only out-of-range values, but any refusal the run's own validation raises qualifies — a wrong const and nonzero reserved reproduce it on the shipped corpus with identical verdicts. And the flat read path's reserved comment dropped the SPEC citation its const twin and the per-field path both carry. One emitted line moves (the citation); goldens re-pinned; wire untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #213 (the #208 review's finding §4 and the §10 citation nit). The consequence bullet now names the full refusal class (wrong
const, nonzeroreserved, out-of-range) — the review reproduced the const case 35x on the shipped corpus with identical verdicts, so the accepted set is unchanged and the comment now says exactly that. The flat read path's reserved refusal gains its(SPEC §4.3)citation. Exactly one emitted line changes;generated/cs/Wire.csand its golden move together; no wire bytes.🤖 Generated with Claude Code