docs: describe the java-functional-style companion boundary - #52
Merged
Merged
Conversation
This was referenced Sep 20, 2026
martinfrancois
added a commit
that referenced
this pull request
Sep 21, 2026
Review of #52: the ownership list was repeated four times with drift and handed method references wholesale to the companion although SKILL.md prefers them for glue. The ownership page now holds the only list, the README carries one paragraph plus the companion install command, the composition check requires the main suite and names the runner's home, AGENTS.md links the page, and workflow.md points runtime changes at the check.
General lambda and callback style now lives in the companion package martinfrancois/java-functional-style. This repository keeps its released runtime bundle byte-identical to v1.2.0 (git diff v1.2.0 -- skills is empty), so the published main score holds by construction, and documents the boundary instead: - README: one paragraph on the companion plus its install command; the full ownership list lives in docs/agents/ownership-boundaries.md. - docs/agents/ownership-boundaries.md: the only ownership list, the rule that each package works on its own, and the composition check that runs this repository's evals with both skills as context (runner in the companion repository; main suite 4/4 at 100% with-context in run 01a0c037-733f-742b-9b10-e62be368d466). - AGENTS.md, skill-behavior.md, workflow.md: links and one sentence each pointing at that page.
martinfrancois
force-pushed
the
refactor/use-java-functional-style
branch
from
September 21, 2026 03:02
774e61e to
89bb451
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
martinfrancois/java-functional-style, and this repository needs to say where the boundary is.docs/agents/ownership-boundaries.mdthat holds the only full ownership list, links fromAGENTS.md,skill-behavior.md, andworkflow.md, and the composition check description.git diff v1.2.0 -- skillsis empty, so the published 2.22x main score stays valid by construction. The earlier commits on this branch that rewroteSKILL.mdand the references were reverted on the branch; they had only been proven in the composed setup, never standalone.Change Type
Linked Issue
Function.identity(); now owned by the companion package)User-Visible Behavior
No runtime change. The README explains that
java-streamsowns stream and collector semantics, thatjava-functional-styleowns general lambda and callback style, that each package works on its own, and that both should be installed together for stream cleanup with non-trivial callbacks.Ownership Boundary
Kept in streams, unchanged: everything in the released
SKILL.md, including the "lambdas as short glue" rule, because the published stream evals measure it.Canonical in
java-functional-style: identity functions, no-op functional stages, method-reference pitfalls, supplier laziness, checked-exception boundaries in callbacks, callback side effects.docs/agents/ownership-boundaries.mdsays not to grow that guidance here.Merge Order
Merge after
martinfrancois/java-functional-styleis public on the Tessl registry (companion PR martinfrancois/java-functional-style-skill#1 first, then its "Make Public" flip). Until then the README's install command points at a package nobody can install.Composition Check
The companion repository ships
scripts/run_composed_eval.sh, which runs this repository's suites with both skills as context. Result for the current branch state:Reference and regression suites were not rerun in the composed setup: this PR changes no runtime text, and the ownership page requires the main suite for runtime changes and the broader suites when budget allows.
Validation
Checks most contributors can run:
python3 scripts/validate_skill.py skills/java-streams-> passedpython3 scripts/validate_eval_criteria.py evals evals-reference evals-regression-> passed,Validated 29 scenario(s): 11 natural, 18 explicit.python3 -m py_compile scripts/*.py-> passedbash -n scripts/*.sh-> passedpython3 scripts/validate_json_files.py-> passedpython3 scripts/validate_openai_agent_yaml.py-> passedtessl plugin lint .-> passedTessl-authenticated checks:
Human Verification
Review Checklist
java-optionalsas the third package of the set; that line is intentional.)docs/agents/workflow.md, or any Tessl blocker is documented. (Not changed.)AI Assistance (if used)
AI prompts / session logs (optional)