docs: describe the java-functional-style companion boundary - #73
Merged
Merged
Conversation
28 tasks done
martinfrancois
added a commit
that referenced
this pull request
Sep 21, 2026
Review of #73: the ownership list was repeated four times with drift, the README section read as maintainer taxonomy and skipped the companion install command, and the composition rule legislated the companion's releases. The ownership page now holds the only list and clarifies that this skill keeps its checked-boundary helper rule, the README carries one paragraph plus the install command, workflow.md points runtime changes at the composition check, and CONTRIBUTING.md names the companion.
Document that java-optionals owns Optional behavior while java-functional-style owns generic lambda, identity-function, no-op functional stage, and callback readability guidance. The runtime skill and eval criteria are unchanged, so existing Optional behavior remains the comparison baseline for any later composition gate. Co-Authored-By: marvinbuff <marvinbuff@hotmail.com> Co-Authored-By: PReimers <preimers@pm.me>
Link the companion repository, keep the lazy-fallback rule documented as measured Optional behavior, and replace the pre-PR gate with the composition check that runs the Optional evals with both skills.
Review of #73: the ownership list was repeated four times with drift, the README section read as maintainer taxonomy and skipped the companion install command, and the composition rule legislated the companion's releases. The ownership page now holds the only list and clarifies that this skill keeps its checked-boundary helper rule, the README carries one paragraph plus the install command, workflow.md points runtime changes at the composition check, and CONTRIBUTING.md names the companion.
martinfrancois
force-pushed
the
refactor/use-java-functional-style
branch
from
September 21, 2026 03:02
17a6085 to
364cfba
Compare
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
martinfrancois/java-functional-style, and this repository needs to say where the boundary is.docs/agents/ownership-boundaries.mdthat holds the only full ownership list, links fromAGENTS.md,skill-behavior.md,readme.md,workflow.md, andCONTRIBUTING.md, and the composition check description.git diff v1.0.0 -- skillsis empty, so the published 2.08x main score stays valid by construction.Change Type
Linked Issue
User-Visible Behavior
No runtime change. The README explains that
java-optionalsowns Optional semantics, thatjava-functional-styleowns general lambda and callback style, that each package works on its own, and that both should be installed together for Optional cleanup with non-trivial callbacks.Ownership Boundary
Kept in optionals, unchanged: everything in the released
SKILL.md, including the lazy-fallback rule, because the published Optional evals measure it.Canonical in
java-functional-style: identity functions, no-op functional stages, method-reference pitfalls, supplier laziness, checked-exception boundaries in callbacks, callback side effects.docs/agents/ownership-boundaries.mdsays not to grow that guidance here.Merge Order
Merge after
martinfrancois/java-functional-styleis public on the Tessl registry (companion PR martinfrancois/java-functional-style-skill#1 first, then its "Make Public" flip). Until then the README's install command points at a package nobody can install.Composition Check
The companion repository ships
scripts/run_composed_eval.sh, which runs this repository's suites with both skills as context. Result for the current branch state:Reference and regression suites were not rerun in the composed setup: this PR changes no runtime text, and the ownership page requires the main suite for runtime changes and the broader suites when budget allows.
Validation
Checks most contributors can run:
python3 scripts/validate_skill.py skills/java-optionals-> passedpython3 scripts/validate_eval_criteria.py evals evals-reference evals-regression-> passed,Validated 52 scenario(s): 4 natural, 48 explicit.python3 -m py_compile scripts/*.py-> passedbash -n scripts/*.sh-> passedpython3 scripts/validate_json_files.py-> passedpython3 scripts/validate_openai_agent_yaml.py-> passedtessl plugin lint .-> passedTessl-authenticated checks:
Human Verification
Review Checklist
java-streamsas the third package of the set; that line is intentional.)docs/agents/workflow.md, or any Tessl blocker is documented. (Not changed.)AI Assistance (if used)
AI prompts / session logs (optional)