test(examples): add signed manifest example coverage - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a signed-manifest example and validation coverage now that the SDK publisher-side signing helpers have landed.
examples/signed-manifest-basic/with a safe, deterministic EdDSA/Ed25519 signed manifest example.npm run validate:examplesto generate and validate the signed example, assert a signature block, and assert private key material is not emitted.Context
signManifest/createSignedManifestpublisher-side helpers.verifyManifestSignature()and test vectors.Parallel safety
This PR avoids core verifier/test-vector/spec paths and MCP runtime files. It does not implement verification, scanner signature checks, CLI
--require-signature, or MCP enforcement. Coverage here is schema-only validation of an example manifest generated by the SDK signing helpers.Files added
examples/signed-manifest-basic/README.mdexamples/signed-manifest-basic/manifest.tspackages/cli/src/tests/signed-examples-regression.test.tsFiles modified
CHANGELOG.mdexamples/README.mdpackages/cli/README.mdscripts/validate-examples.mjsWhat the example demonstrates
createAgentBridgeManifestfollowed bysignManifest.generatedAt,signedAt, andexpiresAtvalues for repeatable tests.kid:test-ed25519-2026-04.agentbridge validateaccepts the signed manifest schema.Validation
npm run typecheck:clean— passednpm test— passed, 23 files / 347 testsnpm run build— passednpm run pack:dry-run— passed, all packages OKnpm run validate:examples— passednpx vitest run packages/cli/src/tests— passed, 4 files / 33 testsnpx tsx examples/signed-manifest-basic/manifest.ts > /tmp/signed-basic.agentbridge.json— passednode packages/cli/dist/bin.js validate /tmp/signed-basic.agentbridge.json— passedSafety confirmations