Repository navigation
CI: run the tests on Node 24 (CVE-2026-111497) - #2
Merged
Merged
Conversation
markhm
force-pushed
the
feature/ci-node-24
branch
from
October 25, 2026 19:53
dd0e53c to
16e7eac
Compare
Node 20 is end-of-life and has no release fixing CVE-2026-111497 (Brotli decoder). setup-node now installs node-version '24' with check-latest, so it looks up the newest 24.x in the actions/node-versions manifest and downloads it when the runner's cached copy is older. Without check-latest the cache supplied 24.21.0, which predates the fixed 24.22.1. actions/checkout and actions/setup-node move from v4 to v7. The runner was already forcing the v4 actions onto Node 24 with a deprecation warning; v7 declares node24 itself, so the warning goes. README and CHANGELOG say Node 24. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
markhm
force-pushed
the
feature/ci-node-24
branch
from
October 25, 2026 20:00
16e7eac to
cc71083
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
testsworkflow ran its test step on Node 20, which is end-of-life and has no release that fixes CVE-2026-111497 (out-of-bounds write in the Brotli decoder). This moves it to Node 24.actions/setup-nodeinstallsnode-version: '24'withcheck-latest: true, so it looks up the newest 24.x in the actions/node-versions manifest and downloads it when the runner's cached copy is older. Withoutcheck-latest, an earlier run of this branch got the cached 24.21.0, which predates the fixed 24.22.1.actions/checkoutandactions/setup-nodego from@v4to@v7, the current majors. This does not change the Node the action code runs on: the runner was already forcing the v4 actions onto Node 24 with a deprecation warning. v7 declaresnode24itself, so the warning goes.Verification
bash test/run.shunder Node 24.16.0: passed 298, failed 0 (macOS bash 3.2).##[warning]lines. The suite's JS checks skip silently whennodeis absent (pre-existingcommand -v node || return 0), so the pass count alone does not prove they ran on 24.22.1; the setup-node step output does.Notes
check-latestdoes not land on master.🤖 Generated with Claude Code