feat(scripts): assign spec-compliant Margo media types to application package resource files - #406
Merged
vireshnavalli merged 2 commits intoSep 15, 2026
Conversation
… resource files Signed-off-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
Signed-off-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
sanjujunnuthula
requested review from
nitparihar and
rishabhrai9616
as code owners
September 11, 2026 09:43
4 tasks
vireshnavalli
approved these changes
Sep 11, 2026
spulkit138
approved these changes
Sep 11, 2026
spulkit138
left a comment
Contributor
There was a problem hiding this comment.
Looks Good! Can be merged if tested.
vireshnavalli
approved these changes
Sep 11, 2026
nitparihar
approved these changes
Sep 14, 2026
rishabhrai9616
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the OCI packaging script (
scripts/modules/packages.sh) to adhere to the Margo Application Registry Specification when pushing application package resource files.Previously, all resource files inside
resources/were pushed as genericapplication/octet-streamlayers. This update inspectsmargo.yaml(and falls back to file name conventions) to assign the appropriate Margo-specific media type and format suffix to each layer.Key Changes
get_margo_media_typeHelper:metadata.catalog.applicationinmargo.yaml(icon,descriptionFile,releaseNotes,licenseFile)..md,.png,.jpg,.txt,.pdf, etc.) to the required format suffixes (+markdown,+png,+jpeg,+plain,+pdf).application/vnd.margo.app.icon.v1+{format}application/vnd.margo.app.descriptionFile.v1+{format}application/vnd.margo.app.releaseNotes.v1+{format}application/vnd.margo.app.licenseFile.v1+{format}application/octet-streaminpush_nextcloud_to_ociandpush_custom_otel_to_ociwith dynamic media type resolution.