fix: roll back failed transaction commits - #316
Merged
chrispader merged 2 commits intoOct 1, 2026
Merged
Conversation
Track transaction finalization states explicitly and preserve commit failures while rolling back deferred constraint errors. Closes margelo#307.
chrispader
added
bug
|
@chrispader is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
Thanks for the PR @huytdps13400 🙌🏼 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A failed COMMIT currently marks the transaction finished before SQLite accepts it, so the wrapper skips rollback and leaves the connection inside the failed transaction. This PR tracks finalization states and attempts rollback after automatic or manual commit failures. A callback that catches a failed manual commit also rejects and rolls back unless it explicitly recovers with rollback.
The wrapper retains the current connection queue and waits for pending async statements before cleanup. If rollback also fails, the error preserves the primary message and exposes both normalized failures through an AggregateError cause. Caught manual rollback failures reject the transaction promise, and failed BEGIN does not roll back a transaction the wrapper did not start.
Reproduction
Enable foreign keys and insert a missing parent reference into a table with a deferred foreign-key constraint inside
transaction(). Automatic commit, manual commit, and a caught manual commit must reject with the foreign-key error, discard the invalid row, and allow a second transaction on the same connection. The example regressions cover these flows; the local wrapper suite also exercises them against real SQLite.Fixes #307.