Ruby CLI: Support --slots on compile and render - #2269
Merged
Conversation
github-actions
Bot
added
ruby
|
View your CI Pipeline Execution ↗ for commit 577577c
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗ ☁️ Nx Cloud last updated this comment at |
marcoroth
added
the
reactivity
🌿 Interactive Playground and Documentation PreviewA preview deployment has been built for this pull request. Try out the changes live in the interactive playground: 🌱 Grown from commit ✅ Preview deployment has been cleaned up. |
commit: |
`--slots` now takes an optional mode, `server` or `client`, and an unknown one is rejected before anything is compiled. `render` ignored `--slots` entirely and never read the `herb:slots` directive, so it could not show what a template actually sends. It now builds the visitor the same way `compile` does, and reads its source once, because reading stdin a second time returns nothing. (cherry picked from commit 19b39e6) (cherry picked from commit e867c3a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--slotsnow takes an optional mode,serverorclient, and an unknown one is rejected before anything is compiled:renderignored--slotsentirely and never read theherb:slotsdirective, so it could not show what a template actually sends.It now builds the visitor the same way
compiledoes, and reads its source once, because reading stdin a second time returns nothing.