Skip to content

fix(darwin): disable PAC mode on set/unset global #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 1 commit into from
Jul 4, 2026
Merged

fix(darwin): disable PAC mode on set/unset global #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sysproxy_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ func setGlobal(ctx context.Context, p *proxy) error {
return err
}
for _, svc := range services {
// Ensure manual proxy mode is authoritative and PAC does not stay active.
_ = runNetworkSetup(ctx, "-setautoproxystate", svc, "off")
Comment on lines +22 to +23
if p.user != "" {
_ = runNetworkSetup(ctx, "-setwebproxy", svc, p.host, p.port, "on", p.user, p.pass)
_ = runNetworkSetup(ctx, "-setsecurewebproxy", svc, p.host, p.port, "on", p.user, p.pass)
Expand All @@ -41,6 +43,8 @@ func unsetGlobal(ctx context.Context) error {
return err
}
for _, svc := range services {
// Unset should clear both manual and auto-proxy modes.
_ = runNetworkSetup(ctx, "-setautoproxystate", svc, "off")
_ = runNetworkSetup(ctx, "-setwebproxystate", svc, "off")
_ = runNetworkSetup(ctx, "-setsecurewebproxystate", svc, "off")
_ = runNetworkSetup(ctx, "-setsocksfirewallproxystate", svc, "off")
Expand Down Expand Up @@ -184,6 +188,8 @@ func setGlobalMulti(ctx context.Context, cfg ProxyConfig) error {
return err
}
for _, svc := range services {
// Multi-protocol manual config should disable PAC mode.
_ = runNetworkSetup(ctx, "-setautoproxystate", svc, "off")
if cfg.HTTP != "" {
_ = runNetworkSetup(ctx, "-setwebproxy", svc, hostFromURL(cfg.HTTP), portFromURL(cfg.HTTP))
_ = runNetworkSetup(ctx, "-setwebproxystate", svc, "on")
Expand Down
Loading