Repository navigation
Add selection line and width/height options, layout tweaks - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a highlighted line within the drag selection, makes the SVG size configurable and adjusts the layout so larger font sizes (e.g. when the profile is displayed small) aren't clipped.
Selection line
selection-lineelement: the part of the line within the selection is drawn on top ofline, clipped to the selected x range only, so its stroke isn't cut at the top.selection-rectandselection-lineuse--maptoolkit-elevation-profile-accentby default.Width/height options
widthandheight(default900×320) set the SVG viewBox and with it the aspect ratio. Fonts and margins are in viewBox units, so a smaller viewBox makes the text relatively larger. Invalid values throw.Layout
Other
minorfor the selection line and the size options,patchfor the padding and the error messages.The default look changes: the plot area is smaller and the selection is drawn in the accent color instead of the line color. Custom CSS for
selection-rectstill applies.