Repository navigation
Use organization workflows for CI, release and pages deployment - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI and release now call the shared workflows from
maptoolkit/.githubinstead of defining the steps here.ci.yml: callsnpm-ci.yml@main(lint, typecheck, test, build — same steps as before). Push runs are limited tomain, PRs run as before. The oldifthat skipped same-repo PRs to avoid duplicate runs is no longer needed.release.yml: callsnpm-release.yml@main(changesets release PR / npm publish, tags and GitHub releases — same steps as before). A newdeploy-pagesjob runs after it when the release outputpublishedis'true'.deploy_pages.yaml→deploy-pages.yml: triggered viaworkflow_callfrom the release workflow (and still manually viaworkflow_dispatch) instead of onv*tag pushes. Tags pushed withGITHUB_TOKENdon't trigger other workflows, so the demo was never deployed automatically after a release. The unusedVITE_MAPTOOLKIT_API_KEYenv is removed, the demo usesdemo/example.geojson.The shared workflows use
actions/checkoutandactions/setup-nodev6 and pinchangesets/actionto v1.9.0.