Skip to content

Fixed pause button not working #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sofian wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fixed pause button not working #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/VideoImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ class VideoImpl
/// Loads a new media source. Subclasses override to set up their player.
virtual bool loadMovie(const QString& filename);

bool setPlayState(bool play);
virtual bool setPlayState(bool play);
bool getPlayState() const { return _playState; }

bool seekIsEnabled() const { return _seekEnabled; }
Expand Down
2 changes: 1 addition & 1 deletion src/core/VideoPlayerImpl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class VideoPlayerImpl : public QObject, public VideoImpl
bool loadMovie(const QString& path) override;
bool isLive() override { return false; }

bool setPlayState(bool play);
bool setPlayState(bool play) override;
bool seekTo(qint64 positionMs) override;
void setRate(double rate) override;
void setVolume(double volume) override;
Expand Down
Loading