Repository navigation
Conversation
acalcutt
changed the title
Collaborator
|
Git conflicts |
mock-aws-s3 (latest 4.0.2) pins underscore@1.12.1, which is affected by GHSA-qpx9-hpmf-5gmw and has no fixed mock-aws-s3 release. Override underscore to ^1.13.8, a backwards compatible minor update. Dev dependency only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nyc 17 depends on istanbul-lib-processinfo, which pulls in uuid < 11.1.1 (GHSA-w5hq-g745-h8pq). nyc 18 drops that dependency. nyc 18 requires Node 20 or >=22, which only affects the dev/coverage tooling; CI already runs on Node lts/-1, lts/* and latest. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
acalcutt
force-pushed
the
mapbox-fix-underscore
branch
from
October 5, 2026 12:06
c59fcdd to
29376e7
Compare
Contributor
Author
|
@cclauss the conflicts should be fixed, this was made before the eslint fixes so it had to be updated |
@istanbuljs/load-nyc-config (used by nyc 17 and 18) depends on js-yaml 3 -> argparse 1 -> sprintf-js, which is affected by GHSA-hp3w-g68c-fv3c with no patched release. js-yaml 4+ uses argparse 2, which has no sprintf-js. The loader only calls js-yaml's load(), which behaves the same in js-yaml 5, and only for .nycrc.yaml files. The override is scoped to @istanbuljs/load-nyc-config, so other js-yaml users are unaffected. Dev dependency only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
|
Sorry if I merged out of order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the remaining
npm auditfindings. Dev dependencies only;npm auditnow reports 0 vulnerabilities (9 on master: 2 high, 7 moderate).overrides(high, GHSA-qpx9-hpmf-5gmw): mock-aws-s3 (latest 4.0.2, used by the S3 tests) pinsunderscore@1.12.1and has no fixed release. 1.13.8 is a backwards compatible minor update.@istanbuljs/load-nyc-configonly (moderate, GHSA-hp3w-g68c-fv3c): nyc's config loader depends on js-yaml 3 → argparse 1 → sprintf-js, which has no patched release. js-yaml 4+ uses argparse 2 without sprintf-js, and the loader only callsload(), which behaves the same. The override is scoped to that package, unlike the global js-yaml override removed in Fix npm ci failing on all CI jobs due to js-yaml override and remove deprecated codecov #997.Checked: clean
npm ciworks,npm run lintpasses,test/s3_setup.test.jspasses, mock-aws-s3 put/list/get work with underscore 1.13.8, coverage runs under nyc 18, and nyc still reads a.nycrc.yaml.