Skip to content

Promote Grep to a standard tool in maproom-researcher's toolbelt - #69

Closed
danielbushman wants to merge 1 commit into
mainfrom
maproom-researcher-grep-toolbelt
Closed

danielbushman wants to merge 1 commit into
mainfrom
maproom-researcher-grep-toolbelt

Conversation

@danielbushman

Copy link
Copy Markdown
Member

Summary

The maproom-researcher agent already had Grep in its tools frontmatter, but the prompt confined it to a single Phase 3 "safety net" coverage sweep with a hard budget of 3 calls. This PR makes Grep a standard part of the toolbelt while keeping maproom the primary search tool — the agent's reason for existing.

Changes (all in plugins/maproom/agents/maproom-researcher.md)

  • Critical Rule 5 rewritten: maproom is primary; Grep is standard for exact-match work (literal strings, known identifiers, regexes, comments/TODOs) in any phase.
  • Phase 1 now says to go straight to Grep for pure exact-match sub-questions instead of spending a maproom search on them.
  • Performance Budget: Grep raised from target 0-3 / max 3 to target 0-4 / max 6, with a note that Grep is not counted by the search-cap hook.
  • Empty-search-results error handling updated to fall back to Grep directly.
  • Changelog entry added; agent version bumped 1.0.0 → 1.1.0.

No hook changes: enforce-search-cap.py only counts maproom search/vector-search Bash calls, so Grep was never hook-limited.

Verification

  • bash plugins/maproom/scripts/verify-docs.sh (what the verify-maproom-docs workflow runs): 11/11 checks pass.
  • Hook untouched; its test suite couldn't run locally (no pytest in this container) but is unaffected by a markdown-only change.

🤖 Generated with Claude Code

Maproom stays the primary search tool — that's why the agent exists —
but Grep is no longer confined to a single Phase 3 safety-net sweep.
The agent may now go straight to Grep for exact-match sub-questions
(literal strings, known identifiers, regexes) in any phase, and the
Grep budget rises from target 0-3 (max 3) to target 0-4 (max 6).
Grep was already in the tools frontmatter and is not counted by the
enforce-search-cap hook, so no hook changes are needed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 148b15b6-5534-4168-95c2-3e2cd2ff018e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch maproom-researcher-grep-toolbelt

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danielbushman

Copy link
Copy Markdown
Member Author

Decided against this change.

@danielbushman
danielbushman deleted the maproom-researcher-grep-toolbelt branch July 27, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant