Skip to content

docs(maproom): replace INTERIM cross-repo guidance with native 0.3.0 flags (plugin 0.10.3) - #68

Open
danielbushman wants to merge 2 commits into
maproom-plugin-docs-refreshfrom
maproom-plugin-cross-repo-docs
Open

danielbushman wants to merge 2 commits into
maproom-plugin-docs-refreshfrom
maproom-plugin-cross-repo-docs

Conversation

@danielbushman

Copy link
Copy Markdown
Member

Summary

  • Replaces the <!-- INTERIM --> "Multi-repo tasks" subsection in maproom-researcher.md with native guidance for --all-repos and repeatable --repo (maproom 0.3.0+)
  • Demotes the pre-0.3.0 per-repo loop to a fallback note in multi-repo-guide.md; supersedes maproom-all wrapper
  • Bumps plugin.json 0.10.2 → 0.10.3
  • Extends verify-docs.sh from 11 to 15 checks, adding automated regression coverage for the new cross-repo content

Merge after cc#70 — this PR depends on maproom 0.3.0 (cross-repo flags) shipped via cc#70.

What changed

plugins/maproom/agents/maproom-researcher.md

  • INTERIM block removed; replaced with native --all-repos / repeatable --repo guidance
  • Per-repo --k cap semantics stated; repo:file:line format noted
  • vector-search subcommand and search --mode hybrid / --mode vector documented as exiting code 2 on multi-repo scope
  • Version floor updated 0.2.0 → 0.3.0 (two locations)
  • Search-budget note: one --all-repos call = one search (prefer over N single-repo calls)

plugins/maproom/skills/maproom-search/references/multi-repo-guide.md

  • New "Native Cross-Repo Search" section replaces loop-based guidance
  • Pre-0.3.0 fallback loop demoted with # Pre-0.3.0 fallback only comment
  • maproom-all wrapper noted as superseded

plugins/maproom/scripts/verify-docs.sh

  • Added checks 12–15: INTERIM absence, 0.3.0 version floor, --all-repos presence, search-budget note
  • TOTAL_CHECKS updated from 11 to 15

Spec

/workspace/_SPECS/crewchief/research/maproom-eco-plugin-cross-repo-docs-spec.md

Validation evidence

verify-docs.sh output:
  Passed: 15 / 15 / Status: ALL CHECKS PASSED

grep -rn INTERIM plugins/maproom → zero hits (excluding verify-docs.sh itself)

Live smoke (against shared Postgres index, 0.3.0 binary):
  maproom search --all-repos --query "authentication middleware" --k 10 --format agent → exit 0, results grouped repo:file:line
  maproom search --repo manifoldlogic/crewchief --repo specs --query "embedding pipeline" --k 10 --format agent → exit 0
  maproom vector-search --all-repos --query "foo" → exit 2
  maproom search --all-repos --mode hybrid --query "foo" → exit 2
  maproom search --all-repos --mode vector --query "foo" → exit 2
  maproom search --all-repos --repo manifoldlogic/crewchief → exit 2 (mutual exclusion)

Review findings resolved / deferred

MUST-FIX — all resolved:

  • maproom-researcher.md line 74: Removed fabricated "10× faster" claim; replaced with "substantially faster" (matching multi-repo-guide.md line 178)
  • Stacked PR opened with "merge after cc#70" note (this PR)
  • verify-docs.sh zero cross-repo coverage: added 4 new checks (12–15) covering INTERIM removal, 0.3.0 floor, --all-repos presence, search-budget note

SHOULD-FIX — all resolved:

  • Scope rules wording: clarified --all-repos vs --repo as two-way mutual exclusion; --repo is one repeatable flag, not two distinct scope types; applied to both maproom-researcher.md and multi-repo-guide.md
  • Terminology: vector-search is a subcommand, hybrid/vector are --mode values on search; now documented distinctly; notes that search --mode vector also exits 2 (not only hybrid)

NOTE — no action needed:

  • SKILL.md line 264 cross-repo note is intentionally minimal (skill-level doc, not agent-level); agent and guide docs carry the complete restriction list

Merge-order notes

This branch is stacked on maproom-plugin-docs-refresh. Merge cc#70 (maproom 0.3.0 binary) and maproom-plugin-docs-refresh before merging this PR.

Non-goals

  • No hook code changes (R6 satisfied: all changes inside plugins/maproom/)
  • No new examples beyond what the spec requires
  • No changes to the session-cap enforcement hook itself

🤖 Generated with Claude Code

danielbushman and others added 2 commits July 10, 2026 01:08
…cross-repo flags

Replace the <!-- INTERIM --> section in maproom-researcher.md with native
--all-repos / repeatable --repo guidance (maproom 0.3.0). Update version
floor 0.2.0 → 0.3.0. Add Native Cross-Repo Search section to
multi-repo-guide.md with per-repo loop demoted to pre-0.3.0 fallback note.
Update SKILL.md Cross-Repo Search Workflow with single-invocation examples.
Bump plugin.json 0.10.2 → 0.10.3. Verified live: --all-repos and
repeatable --repo confirmed working; vector-search exits 2 on multi-repo
scope as documented. verify-docs.sh 11/11.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…gression coverage

- Remove fabricated '10× faster' claim; replace with 'substantially faster' (matching multi-repo-guide.md)
- Clarify scope rules: --all-repos and --repo are two-way mutually exclusive; --repo is one repeatable flag, not two separate scope types
- Fix terminology: 'vector-search' is a subcommand, 'hybrid'/'vector' are --mode values on search; document both paths that exit 2 on multi-repo scope
- Apply same scope-rules and mode-terminology fixes to multi-repo-guide.md for consistency
- Add 4 new checks to verify-docs.sh (checks 12-15): INTERIM absence, 0.3.0 version floor, --all-repos presence, search-budget note — closes TEST ADEQUACY gap flagged in review
- verify-docs.sh now passes 15/15

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fb22d27a-7a13-413d-899c-9ffcd3217eed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch maproom-plugin-cross-repo-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant