Repository navigation
docs(maproom): Postgres backend accuracy pass — plugin 0.10.2 - #67
Open
danielbushman wants to merge 2 commits into
Open
danielbushman wants to merge 2 commits into
danielbushman wants to merge 2 commits into
Conversation
- concept-glossary.md: expand SQLite entry to cover both backends; describe shared-Postgres via MAPROOM_DATABASE_URL, note localhost:5433 as cargo-test-only sandbox, maproom status as canonical probe - troubleshooting.md GAP-004/005/006: add "SQLite backend only" banners; add Postgres Connectivity Issues section (health check, connection string, common error table, FTS-vs-embeddings note) - embedding-providers.md + adc-setup.md: add status banners noting embeddings not generated by default in shared-PG; FTS operative; docs remain valid when embeddings are enabled - README.md L42 + L114: reframe database-location as backend-agnostic (MAPROOM_DATABASE_URL / maproom status); retain SQLite path for SQLite users - maproom-researcher.md: version floor 0.1.0 → 0.2.0; add INTERIM multi-repo tasks subsection (status --json enumeration, per-repo loop, maproom-all as local convenience, --repo specs availability, no --all-repos) - plugin.json: 0.10.1 → 0.10.2 (PATCH per repo convention) - verify-docs.sh: 11/11 checks pass Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- Bump EXPECTED_VERSION in monthly-cli-verification.sh from 0.1.0 to 0.2.0
(was causing immediate DRIFT on every scheduled CI run)
- Update README.md minimum version floor from 0.1.0 to 0.2.0 at all three
occurrences (lines 37, 183, 202) — eliminates intra-plugin contradiction
with researcher.md's 0.2.0 requirement
- Fix concept-glossary.md Storage Backend entry: remove devcontainer-specific
prose ("In this devcontainer"), correct shared backend from PG14 to PG16,
make addresses illustrative ("e.g.") rather than normative
- Fix troubleshooting.md Connection String section: replace
"Expected: <devcontainer-URL>" with a portable placeholder; add devcontainer
form as a labelled example only
- Fix troubleshooting.md quick-check block: bump version comment 0.1.0→0.2.0
- Add inline note that the docker container name is environment-specific
verify-docs.sh: 11/11 PASS; monthly-cli-verification.sh: no DRIFT
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--all-reposflag.What changed
.claude-plugin/plugin.jsonagents/maproom-researcher.mdskills/maproom-guide/references/concept-glossary.mdskills/maproom-search/references/troubleshooting.mdREADME.mdscripts/monthly-cli-verification.shSpec
_SPECS/crewchief/research/maproom-eco-plugin-backend-docs-refresh-spec.md
Validation evidence
bash plugins/maproom/scripts/verify-docs.sh→ 11/11 PASSbash plugins/maproom/scripts/monthly-cli-verification.sh→ No DRIFT (Check 2: Version matches expected 0.2.0)maproom --version→maproom 0.2.0pgvector/pgvector:pg16) viapsql SELECT version()psql localhost:5433/maproom_testReview findings resolved / deferred
MUST-FIX — all resolved:
monthly-cli-verification.shEXPECTED_VERSION 0.1.0 → 0.2.0 — FIXEDREADME.mdminimum version 0.1.0 at lines 37, 183, 202 — FIXED (all three occurrences updated to 0.2.0)concept-glossary.md"In this devcontainer" + PG14 misidentification of shared backend — FIXED (prose now says "In shared-Postgres devcontainer setups"; addresses marked ase.g.; PG16 noted for shared backend)troubleshooting.mdConnection StringExpected:showing devcontainer-only URL as canonical — FIXED (placeholderpostgres://user:pass@host:port/dbnameis now the Expected value; devcontainer form added as a labelled example)SHOULD-FIX — all resolved (cheap and clearly correct):
troubleshooting.mdquick-check version comment 0.1.0 → 0.2.0 — FIXEDtroubleshooting.mddocker ps --filter name=maproom-postgres— FIXED (inline comment added: "replace maproom-postgres with your actual container name")NOTE findings — deferred (informational, DoD does not require action):
newgrp docker): Correct diagnostic for the devcontainer environment; adding a note would increase noise in a section aimed at diagnosing maproom errors, not container permission issues. Deferred.Non-goals
--all-reposusage (unshipped flag); INTERIM block is fenced.🤖 Generated with Claude Code