resolver: include metadata in fetch - #84
Open
Ratakor wants to merge 5 commits into
Open
Conversation
Contributor
|
it's a good start, but I'd really like to figure out something that works for fetchTree, FOD etc as well. also still not sure I want the metadata riding on the input itself vs a do you have any desire to expand the PR in this direction ? I'm happy to take up work on it, if not - it has been an open issue for a while. |
Signed-off-by: Ratakor <ratakor@disroot.org>
Signed-off-by: Ratakor <ratakor@disroot.org>
Signed-off-by: Ratakor <ratakor@disroot.org>
Signed-off-by: Ratakor <ratakor@disroot.org>
Signed-off-by: Ratakor <ratakor@disroot.org>
Author
|
I think it's fine if metadata is available at toplevel since sourceInfo is already present in flakes by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #60
Include metadata from pins.lock.json by default if pin.type = "fetch".
This mimics npins behavior to some degree.
I don't know if we should do something similar for "fixed" type. I don't think it's useful for "flake" type and it's kind of annoying to provide it by default.