Skip to content

resolver: include metadata in fetch - #84

Open
Ratakor wants to merge 5 commits into
manic-systems:mainfrom
Ratakor:main
Open

resolver: include metadata in fetch#84
Ratakor wants to merge 5 commits into
manic-systems:mainfrom
Ratakor:main

Conversation

@Ratakor

@Ratakor Ratakor commented Jul 8, 2026

Copy link
Copy Markdown

closes #60

Include metadata from pins.lock.json by default if pin.type = "fetch".
This mimics npins behavior to some degree.

I don't know if we should do something similar for "fixed" type. I don't think it's useful for "flake" type and it's kind of annoying to provide it by default.

@atagen

atagen commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

it's a good start, but I'd really like to figure out something that works for fetchTree, FOD etc as well.

also still not sure I want the metadata riding on the input itself vs a _meta at the root.
if the sub-attribute may not be able to work that way for all fetchers, and may also be a forwards compatibility issue.
I definitely want something like this to be as consistent and opt-in as possible.

do you have any desire to expand the PR in this direction ? I'm happy to take up work on it, if not - it has been an open issue for a while.

Ratakor added 3 commits July 23, 2026 16:09
Signed-off-by: Ratakor <ratakor@disroot.org>
Signed-off-by: Ratakor <ratakor@disroot.org>
Signed-off-by: Ratakor <ratakor@disroot.org>
Ratakor added 2 commits July 23, 2026 16:48
Signed-off-by: Ratakor <ratakor@disroot.org>
Signed-off-by: Ratakor <ratakor@disroot.org>
@Ratakor

Ratakor commented Jul 23, 2026

Copy link
Copy Markdown
Author

I think it's fine if metadata is available at toplevel since sourceInfo is already present in flakes by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

retrieve rev, hash, owner, repo, etc in nix

2 participants