Repository navigation
26-ITP-May | Onboarding | Mandip Sanger #49
Description
-
Wireframe PR
https://github.com/CodeYourFuture/Module-Onboarding/pull/1441 -
Form-Controls PR
https://github.com/CodeYourFuture/Module-Onboarding/pull/1440 -
Screenshot of Demoseesion
4. https://www.codewars.com/users/mandipsanger
Activity
mandipsanger commentedon Jun 12, 2026
I have finished all the tasks.
cjyuan commentedon Jun 12, 2026
Regarding your Form-Controls implementation, could you check the spec in README carefully to see which TWO of the requirements have not yet been met, and then update your code accordingly?
cjyuan commentedon Jun 12, 2026
Could you make the values of the select element more consistent?
I think your current implementation (after changes) still miss a requirement. To fix it you would probably need to update your CSS code.
You could also try showing your code to an AI tool and ask it to give you feedback.
cjyuan commentedon Jun 12, 2026
Much better now. I think one of the sizes could still be expressed more consistently.
After you changed the CSS recently, did you check if it looks ok?
mandipsanger commentedon Jun 12, 2026
I had changed values there was this issue on Lighthouse accessibility is between 90-100 (was unable to download a robots.txt file)
Please check as I was aware accessibility is always between that range.
cjyuan commentedon Jun 12, 2026
Lighthouse accessibility score is now 100.
CSS style is not assessed in the Form-Control exercise, so you could try to address the "imperfect look" later when you have time.
I still think one of the sizes looks differently from the others. I mean the way you name the size. (You can try asking AI to check for consistency)
mandipsanger commentedon Jun 12, 2026
mandipsanger commentedon Jun 12, 2026
I have changed on VS and pushed and sync changed the value from XXL to -- Please choose an option --
XXL or
Do you mean sizes in the CSS?
cjyuan commentedon Jun 12, 2026
XXL. Other sizes are expressed in words.
mandipsanger commentedon Jun 12, 2026
done