[oshchyhol]

Motivation

The organization client can list and create sub accounts but has no way to delete one. This adds the DELETE /api/organizations/{organization_id}/sub_accounts/{sub_account_id} operation.

Changes

• new IOrganizationSubAccountResource with Delete(), reached via IOrganizationResource.SubAccount(long subAccountId)
• SubAccount(id) rejects ids less than or equal to zero with ArgumentOutOfRangeException, like the other single-resource getters
• XML docs cover the operation's behaviour – requires organization admin permissions and the Organization & Sub-accounts feature (403 otherwise), permanent and removes all sub account data, deleting the last sub account deletes the organization, repeated call returns 404, concurrent call returns 409, rate limit of 10 requests per minute per organization
• Mailtrap.Example.SubAccount deletes the sub account it created, with a comment that deleting needs an organization admin token and the Organization & Sub-accounts feature

How to test

Use an organization API token with organization admin permissions and a fresh sub account created via organization.SubAccounts().Create(...).

• await organizationClient.Organization(orgId).SubAccount(subAccountId).Delete() completes without an exception; the sub account is gone from SubAccounts().GetAll()
• call Delete() again on the same id – HttpRequestFailedException with status 404
• call Delete() with a sub account id that belongs to another organization – status 404
• call Delete() with a token that only has sub account management permissions – status 403
• call Delete() in an organization without the Organization & Sub-accounts feature – status 403
• call Delete() with an invalid token – status 401
• SubAccount(0) and SubAccount(-1) throw ArgumentOutOfRangeException before any request is sent
• dotnet run --project examples/Mailtrap.Example.SubAccount lists, creates and then deletes the demo sub account, logging Deleted Sub Account: Id=...

Companion PRs

• backend endpoint (in production)
• document the delete organization sub account endpoint mailtrap-openapi#56 – spec
• add sub account deletion mailtrap-nodejs#159 – nodejs SDK
• add sub account deletion mailtrap-ruby#130 – ruby SDK
• Add SubAccountsApi.delete for DELETE /api/organizations/{id}/sub_accounts/{id} mailtrap-python#83 – python SDK
• Add deleteSubAccount for organization sub-accounts mailtrap-php#80 – php SDK
• add sub account deletion mailtrap-java#75 – java SDK
• fix the permission note for deleting a sub-account mailtrap-go#41 – go SDK permission note (Delete shipped in v0.4.0)
• add sub-account deletion to the CLI mailtrap-cli#15 – CLI
• add delete-sub-account tool mailtrap-mcp#144 – MCP server

[coderabbitai]

Important

• Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: fa5d7e96-6060-4f8f-b5bc-feea58735a57

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn