Skip to content

Fix ConsoleRender.height returning terminal.width #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cristianchiriac wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix ConsoleRender.height returning terminal.width #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/inquirer/render/console/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,4 +185,4 @@ def width(self):

@property
def height(self):
return self.terminal.width or 24
return self.terminal.height or 24
8 changes: 8 additions & 0 deletions tests/integration/console_render/test_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import unittest
from unittest.mock import MagicMock

import inquirer.errors as errors
import inquirer.questions as questions
Expand All @@ -13,3 +14,10 @@ def test_rendering_erroneous_type(self):
sut = ConsoleRender()
with self.assertRaises(errors.UnknownQuestionTypeError):
sut.render(question)

def test_height_uses_terminal_height_not_width(self):
sut = ConsoleRender()
sut.terminal = MagicMock(width=123, height=45)

self.assertEqual(sut.height, 45)
self.assertEqual(sut.width, 123)