fix(crm): show retired stage names in list cells

[synoet]

Why

PR #4822 trimmed Qualified, Trial, and Negotiation out of the default stage picker. Group headers still resolve those ids through getPropertyOptionLabel, so a Negotiation group still says Negotiation. List cells go through soupPropertyToProperty → formatPropertyValue → formatOptionValueById, and that last step used only property.options. After the trim, SYSTEM_PROPERTY_OPTIONS for Stage is COMPANY_STAGE_OPTIONS (Lead, Demo, Customer, Churned). A stored Negotiation id therefore printed as 00000001-0000-0000-0010-000000000005.

The picker should stay trimmed. The Set-stage modal reads property.options. Putting ALL_COMPANY_STAGE_OPTIONS back on SYSTEM_PROPERTY_OPTIONS would offer retired stages again.

Scope

formatOptionValueById in apps/web/src/features/property/utils/formatting.ts still prefers a match in property.options. If that list has no match, it asks getPropertyOptionLabel before it falls back to the raw id.

apps/web/src/features/entity/extractors-property/property-helpers.test.ts formats Lead, Demo, Customer, Churned, Qualified, Trial, and Negotiation through soupPropertyToProperty + formatPropertyValue.

Out of scope: the Set-stage modal, backend option lists, and group-header labeling.

Tradeoffs

Display labels and picker options stay on two catalogs. ALL_COMPANY_STAGE_OPTIONS is the label table. COMPANY_STAGE_OPTIONS is the picker set. A one-list change would be smaller and would put retired stages back in the modal.

The import is @entity/utils/task-properties, not the @entity barrel, so the extractors → @property/utils cycle does not close.

Blast Radius

Any select cell that formats through formatPropertyValue now can show a catalog label for an id missing from property.options. Unknown ids still print as ids. Current picker stages are unchanged.

CRM users who still have Negotiation, Qualified, or Trial on a company see the name in the list cell, matching the group header.

Verification

Isolated vitest on property-helpers.test.ts: 7 passed, including the three retired stage ids.

Customers list on the local stack, List mode, Group by Stage. gloxco Stage cell shows Negotiation, not the option id. OSC still shows Customer. Qualco and Trialco show Qualified and Trial.

gloxco Stage cell shows Negotiation
customers_list_retired_stage_cells_show_names.mp4

_{To show artifacts inline, enable in settings.}

  

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5869191f-29d9-4c13-9389-0a78efd9582b

📥 Commits

Reviewing files that changed from the base of the PR and between e56ac85 and 39de836.

📒 Files selected for processing (2)

• apps/web/src/features/entity/extractors-property/property-helpers.test.ts
• apps/web/src/features/property/utils/formatting.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes

  • Improved formatting for property option values by displaying the appropriate label when available, with a reliable fallback for unmatched options.

• Tests

  • Added coverage to verify that system stage options are consistently displayed using their expected labels.

Walkthrough

Updated property option formatting to resolve labels through the shared property-option lookup when option data is unavailable. The formatter still formats matching options and falls back to the raw option ID. Added parameterized tests for all supported stage option IDs through soupPropertyToProperty and formatPropertyValue.

Merge Risk: ⚪ Minimal · up to 39de8

The change restores readable labels for retired CRM stages without re-enabling those stages in the picker or changing stored data, APIs, permissions, or deployment behavior; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses the conventional commits format, describes the CRM stage-label fix, and is 48 characters long, which is under the 72-character limit.
Description check	✅ Passed	The description clearly explains the retired stage-label issue, the formatting change, test coverage, scope, tradeoffs, and verification results.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Preview: https://synoet-crm-negotiation-stage-l-1c7ivp.preview.macro.com/app (f8668d0)