Skip to content

fix(agent-trigger): keep rdkafka out of the self-hosted daemon - #6040

Merged
404Wolf merged 1 commit into
mainfrom
cursor/keep-rdkafka-out-of-daemon-be67
Aug 31, 2026
Merged

fix(agent-trigger): keep rdkafka out of the self-hosted daemon#6040
404Wolf merged 1 commit into
mainfrom
cursor/keep-rdkafka-out-of-daemon-be67

Conversation

@404Wolf

@404Wolf 404Wolf commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Implicit quote-reply detection added lexical_client to agent_trigger as a required dep. That pulls models_search → notification → rdkafka into coding_agent_worker, so the musl zigbuild dies on librdkafka 2.12's unconditional curl/curl.h include.

Gate the outbound adapters behind a feature. The trigger and harness services enable it; the daemon only needs domain events.


Note

Low Risk
Cargo feature and dependency wiring only; services that need outbound explicitly opt in, so runtime behavior for those binaries should be unchanged.

Overview
agent_trigger no longer pulls lexical_client (and the transitive rdkafka chain) by default. Lexical/fast-model outbound code is behind a new outbound Cargo feature that optionally enables agent, ai_usage, and lexical_client; the outbound module is only compiled when that feature is on.

agent_trigger_service and agent_harness_service now depend on agent_trigger with features = ["outbound"], so they keep building the adapters. Consumers that only need domain events (e.g. the self-hosted coding_agent_worker daemon) can stay on the default feature set and avoid linking Kafka/openssl for static musl builds.

Reviewed by Cursor Bugbot for commit b18fbc8. Bugbot is set up for automated code reviews on this repo. Configure here.

Implicit quote-reply detection added lexical_client to agent_trigger as a
required dep. That pulls models_search → notification → rdkafka into
coding_agent_worker, so the musl zigbuild dies on librdkafka 2.12's
unconditional curl/curl.h include.

Gate the outbound adapters behind a feature. The trigger and harness
services enable it; the daemon only needs domain events.

Co-authored-by: Wolf Mermelstein <wolf@404wolf.com>
@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5338249e-cca6-4f31-8ebe-708143d97f8f

📥 Commits

Reviewing files that changed from the base of the PR and between e56ac85 and b18fbc8.

📒 Files selected for processing (4)
  • crates/agent_trigger/Cargo.toml
  • crates/agent_trigger/src/lib.rs
  • services/agent_harness_service/Cargo.toml
  • services/agent_trigger_service/Cargo.toml

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Improvements
    • Reduced the default application footprint by making outbound agent integrations optional.
    • Enabled outbound event capabilities for services that require them.
    • Consumers using only domain events no longer need to include the outbound integration stack by default.

Walkthrough

The agent_trigger crate now provides an opt-in outbound feature. The feature enables the optional agent, ai_usage, and lexical_client dependencies and conditionally compiles the outbound module. The agent harness and agent trigger services enable this feature in their agent_trigger dependencies.

Merge Risk: ⚪ Minimal · up to b18fb

The change keeps outbound dependencies out of the self-hosted daemon while explicitly preserving them for services that need them. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title uses conventional commits format with the fix type, describes the dependency change, and is 62 characters long.
Description check ✅ Passed The description clearly explains the feature-gating change, affected services, and the rdkafka build issue it addresses.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@404Wolf
404Wolf merged commit 0b5b4b9 into main Aug 31, 2026
34 checks passed
@404Wolf
404Wolf deleted the cursor/keep-rdkafka-out-of-daemon-be67 branch August 31, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants