fix(agent-trigger): keep rdkafka out of the self-hosted daemon - #6040
Conversation
Implicit quote-reply detection added lexical_client to agent_trigger as a required dep. That pulls models_search → notification → rdkafka into coding_agent_worker, so the musl zigbuild dies on librdkafka 2.12's unconditional curl/curl.h include. Gate the outbound adapters behind a feature. The trigger and harness services enable it; the daemon only needs domain events. Co-authored-by: Wolf Mermelstein <wolf@404wolf.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Merge Risk: ⚪ Minimal · up to The change keeps outbound dependencies out of the self-hosted daemon while explicitly preserving them for services that need them. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Implicit quote-reply detection added lexical_client to agent_trigger as a required dep. That pulls models_search → notification → rdkafka into coding_agent_worker, so the musl zigbuild dies on librdkafka 2.12's unconditional curl/curl.h include.
Gate the outbound adapters behind a feature. The trigger and harness services enable it; the daemon only needs domain events.
Note
Low Risk
Cargo feature and dependency wiring only; services that need outbound explicitly opt in, so runtime behavior for those binaries should be unchanged.
Overview
agent_triggerno longer pullslexical_client(and the transitiverdkafkachain) by default. Lexical/fast-model outbound code is behind a newoutboundCargo feature that optionally enablesagent,ai_usage, andlexical_client; theoutboundmodule is only compiled when that feature is on.agent_trigger_serviceandagent_harness_servicenow depend onagent_triggerwithfeatures = ["outbound"], so they keep building the adapters. Consumers that only need domain events (e.g. the self-hostedcoding_agent_workerdaemon) can stay on the default feature set and avoid linking Kafka/openssl for static musl builds.Reviewed by Cursor Bugbot for commit b18fbc8. Bugbot is set up for automated code reviews on this repo. Configure here.