Add k8s-review, gitops-review, helm-review and a gitops set - #34
Merged
Conversation
Three bundled reviews for Kubernetes and GitOps repos: - k8s-review: manifests and kustomize structure. Cross-resource reference integrity, immutable-field traps, API deprecations with the version boundary named, and structural kustomize defects: resources that should be Components and the inverse, fake components/ directories, overlay copy-paste, deprecated fields (commonLabels, patchesStrategicMerge, bases, vars), generator misuse. Schema validation is scoped to rendered kustomize build output so patch files (JSON6902 op lists, strategic-merge fragments) never produce false positives. - gitops-review: the Argo CD / Flux delivery layer. Source pinning, sync and prune posture, ordering and health, ApplicationSet blast radius, tenancy, Flux API currency, secrets delivery (SOPS, sealed, external), image automation, and environment promotion. Gates on evidence: when manifests carry no tool markers it says the tool is undetectable and reviews tool-agnostically; vendored Argo/Flux installations are in scope. - helm-review: chart authoring. Template correctness (quoting, nindent, nil guards, name truncation), rendering-environment honesty (lookup and Capabilities under helm template), the values contract, rollout correctness (checksums, versioned selector labels), hooks, CRD lifecycle, and chart metadata and dependencies. Each prompt delegates pod-spec posture to container-review, CI/IaC to infra-review, and secret values to sec-review, mirroring the bundled delegation style in both directions. Wiring: a gitops set (the three new reviews plus container-review, infra-review, sec-review, dr-review), helper tools registered in agent.ReviewTools (kubeconform, kustomize, helm, kube-linter, kube-score, pluto, yq), file-signal suggester rules for kustomize/GitOps/chart markers, contract snapshots, README grid, CLI docs, and a CHANGELOG entry.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds GitOps/Kubernetes review coverage as three bundled prompts plus a
gitopsset.New reviews
k8s-review— manifests and kustomize structure: cross-resource reference integrity (dangling Service selectors, missing ConfigMap/Secret keys, broken roleRefs), immutable-field traps queued in the repo, API deprecations with the version boundary named, and structural kustomize defects — resources that should be Components and the inverse,components/directories holding plain resource lists, overlay copy-paste, deprecated fields (commonLabels,patchesStrategicMerge,bases,vars), generator misuse. Schema validation is explicitly scoped to renderedkustomize buildoutput so JSON6902 op lists and strategic-merge fragments never produce false positives, and unknown (CRD-typed) kinds are skipped rather than reported.gitops-review— the Argo CD / Flux delivery layer: source pinning (targetRevision: HEAD, semver-matches-tags-only, unpinned remote bases and chart ranges), sync/prune/selfHeal tradeoffs, Flux's prune-off default, ordering and health (waves, hook delete policies, cross-kinddependsOn), ApplicationSet blast radius andgoTemplateOptions, tenancy scoping, deprecated*.toolkit.fluxcd.iobeta APIs, secrets delivery (SOPS wiring, sealed/external secrets), image automation, and environment promotion. Gates on evidence: when manifests carry no tool markers it states the tool is undetectable and reviews tool-agnostically instead of guessing; repos vendoring the Argo CD/Flux installation itself are in scope.helm-review— chart authoring: template correctness (quoting/retyping,nindent, nil guards,$rebinding, 63-char truncation), rendering-environment honesty (lookupand.Capabilitiesunderhelm template, i.e. the GitOps render path), the values contract (values.schema.json, dead/undocumented values, subchart wiring), rollout correctness (checksum annotations, versioned selector labels), hooks (delete policies, weights, phase mismatches), CRD lifecycle (crds/vstemplates/), and chart metadata/dependencies.Each prompt follows the bundled format (Summary line, applicability gate with skip instruction, surface section, numbered focus areas, shared report structure) and delegates in both directions: pod-spec posture stays with
container-review, CI/IaC withinfra-review, secret values withsec-review, re-run safety withidempotency-review.Wiring
gitopsset: the three new reviews pluscontainer-review,infra-review,sec-review,dr-review.agent.ReviewToolsentries (kubeconform, kustomize, helm, kube-linter, kube-score, pluto, yq) so the composed tooling note works; doctor's exactly-once catalog check passes.flux-system/argocd/gotk files), andChart.yaml.goldenReviewNames,goldenSetNames), README review grid and set list,docs/CLI.mdsets line, CHANGELOG entry under Unreleased.Verification
gofmt -lclean,go build ./..., fullgo test ./...green.gauntlet -r gitops --dry-runexpands to the 7 expected reviews.gauntlet --show-prompt k8s|gitops|helmcomposes with a correct tooling note (installed vs absent helpers reflected).