Repository navigation
Expose rejected handshake response headers in Error events - #637
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a server rejects a WebSocket handshake, applications receive its HTTP status and reason but cannot inspect response headers such as Retry-After or custom authentication details.
Add
WebSocketErrorInfo::headersand populate it from the existingWebSocketInitResultheaders when reporting a connection error. Document access throughmsg->errorInfo.headers. This is a small C++11-compatible API addition; header parsing is unchanged.Closes #636.
Validation:
git diff --checkpass.