Fix AF_INET6 accept() address handling#568
Closed
mrexodia wants to merge 2 commits intomachinezone:masterfrom
Closed
Fix AF_INET6 accept() address handling#568mrexodia wants to merge 2 commits intomachinezone:masterfrom
mrexodia wants to merge 2 commits intomachinezone:masterfrom
Conversation
mrexodia
force-pushed
the
ipv6-accept-fix
branch
from
6ff4869 to
0d61ea8
Compare
Contributor
Author
|
CI failure was fixed by pinning mbedtls to v3 on brew. |
mrexodia
changed the title
Contributor
|
Is this similar to #571 ? |
Contributor
|
The fix is the same as in #571, so I would say yes. |
Contributor
Author
|
It’s the same but CI is actually passing 😉 (and the my code is cleaner) |
Contributor
|
Ah, my bad, my PR is missing this PR's 4eec026 commit. |
Contributor
No need for the snarky reply. The other PR is fixing a different issue and I happened to need an additional fix that you have already done but didn't see. I can revert my commit and they can use your PR for that specific part, I don't care. |
Contributor
Author
|
As long as the issue gets fixed I'm happy 🤷🏻♂️ |
Collaborator
|
Thanks, all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6 year old FIXME mrexodia@b213063