Skip to content

Fix naming inconsistency: TargetBotCore → TargetCore - #3

Merged
mCodex merged 2 commits into
feat/bot_core_modulefrom
copilot/sub-pr-2
Dec 10, 2025
Merged

mCodex merged 2 commits into
feat/bot_core_modulefrom
copilot/sub-pr-2

Conversation

Copilot AI commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

The module is named TargetCore but was referenced as TargetBotCore in 11 locations across comments and documentation.

Changes:

  • Code comments (targetbot/target.lua, targetbot/creature_attack.lua): Updated references in DRY principle comments and utility function documentation
  • Documentation (docs/TARGETBOT.md, docs/PERFORMANCE.md, README.md, ROADMAP.md): Updated section headings, code examples, and feature tables
-- Before
-- Use TargetBotCore if available (DRY principle)
TargetBotCore.Geometry = { ... }

-- After  
-- Use TargetCore if available (DRY principle)
TargetCore.Geometry = { ... }

No functional changes—documentation and comment alignment only.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ghout codebase

Co-authored-by: mCodex <5920613+mCodex@users.noreply.github.com>
Copilot AI changed the title [WIP] Update bot core module based on review feedback Fix naming inconsistency: TargetBotCore → TargetCore Dec 10, 2025
Copilot AI requested a review from mCodex December 10, 2025 19:38
@mCodex
mCodex marked this pull request as ready for review December 10, 2025 19:46
Copilot AI review requested due to automatic review settings December 10, 2025 19:46
@mCodex
mCodex merged commit c183f7c into feat/bot_core_module Dec 10, 2025
@mCodex
mCodex deleted the copilot/sub-pr-2 branch December 10, 2025 19:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects a naming inconsistency where the module TargetCore was incorrectly referenced as TargetBotCore in 11 locations across code comments and documentation files.

  • Updates all references from TargetBotCore to TargetCore to match the actual module name defined in targetbot/core.lua
  • Affects only comments and documentation—no functional code changes
  • Improves code clarity and consistency across the codebase

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
targetbot/target.lua Updated 2 comment references in DRY principle comments and distance calculation utility
targetbot/creature_attack.lua Updated 4 comment references in header, wave avoidance system, and utility function documentation
docs/TARGETBOT.md Updated feature list bullet point describing pure function scoring
docs/PERFORMANCE.md Updated section heading and code example showing geometry calculations
ROADMAP.md Updated feature checklist item for TargetCore module
README.md Updated design patterns table entry for pure functions

Review Summary: All changes are accurate and consistent. The PR successfully corrects all 11 instances of the incorrect TargetBotCore name to the correct TargetCore module name. No functional code was modified—only comments and documentation were updated. No issues found.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants