fix(pmk): Recommendation 팝업 개선 - #94
Merged
Merged
Conversation
- NodeGroup 없는 경우: GetAvailableK8sVersion으로 K8s 버전 동적 조회 후 version 필드 설정 - NodeGroup 없는 경우: 불필요한 pre-validation(checkK8sClusterDynamic) 제거 - NodeGroup 없는 경우: GetAvailableK8sNodeImage 호출 제거 (UNDER DEVELOPMENT API) - NodeGroup 없는 경우: CSP별 하드코딩 specId/imageId 제거 → imageId는 "default" 사용 - NodeGroup 있는 경우: pre-validation 유지 - pmk_api.js: getAvailablek8sClusterNodeImage await 누락 수정 및 반환값 통일
- desiredNodeSize/minNodeSize/maxNodeSize/rootDiskSize를 int로 변환 (tumblebug 타입 불일치 해소) - createNode 검증을 name/specId/imageId 필수로 완화 (autoScaling OFF 시 min/maxNodeSize 없음) - clustercreate.js에서 createNode await 추가 및 검증 실패 시 early return 처리 - RecommendK8sNode 실패 시 CSP별 default specId fallback 적용 (NodeGroup-less 배포용)
- Add Node 시 Spec Recommendation 팝업에서 선택된 클러스터의 provider 자동 필터링 (selectedPmkObj fallback 추가 — cluster_provider_dynamic이 없는 경우 대응) - Image Recommendation 팝업에 is Kubernetes Image 토글 추가 (기본 ON) K8s 이미지가 없을 때 OFF로 전환해 전체 이미지 재조회 가능
fix(pmk): PMK Recommendation 팝업 개선
MZC-CSC
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spec Recommendation provider 필터 (
pmk_serverrecommendation.js,clustercreate.js)shown.bs.modal에서cluster_provider_dynamic없을 경우selectedPmkObj[0].providerfallbackImage Recommendation K8s 필터 (
pmk_imagerecommendation.js,_pmk_imagerecommendation.html)isKubernetesImage하드코딩 제거 → 체크박스 값 반영