Update MC-Cost-Optimizer Docker images to version 0.6.3 - #188
Merged
Conversation
Added environment variables for OPENBAO configuration and S3 region.
Removed timezone setting for the mc-cost-optimizer service.
Added timezone setting for containers in docker-compose.
BE now needs to call azure-vm-rightsizer, ncp-vm-rightsizer, and gcpCollector directly for on-demand batch triggers, but only costcollector/costprocessor/costselector URLs were wired. - add MC_COST_OPTIMIZER_AZURE_RIGHTSIZER_URL / NCP_RIGHTSIZER_URL - fix MC_COST_OPTIMIZER_COST_GCP_COLLECTOR_URL hostname (pointed at mc-cost-optimizer-cost-gcp-collector, a container that doesn't exist; the real service is mc-cost-optimizer-gcp-collector) - wire all three into mc-cost-optimizer-be's environment
latest currently resolves to 12.3.2 anyway (same digest, verified via docker pull), so this only removes the drift risk on future redeploys - no behavior change today.
…alarm URLs
- costopti.azurecollector.url / costopti.ncpcollector.url: BE needs
these to trigger Azure/NCP budget checks on demand, only
azurerightsizer/ncprightsizer/gcpcollector were wired.
- ALARM_SERVICE: costCollector's application.properties expects this
env var (costopti.alarmservice.url=${ALARM_SERVICE:alarm_service})
but it was never set here, so AWS budget alarms failed with
"URI is not absolute" trying to reach the literal string
"alarm_service" instead of a real URL.
Both env vars (MC_COST_OPTIMIZER_COST_AZURE_COLLECTOR_URL,
MC_COST_OPTIMIZER_COST_NCP_COLLECTOR_URL, MC_COST_OPTIMIZER_ALARM_URL)
already existed in .env.setup - just weren't wired into these services.
MZC-CSC
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.