[WRONG BRANCH] fix(xai): constrain hosted search tool names - #334
Draft
luvs01 wants to merge 1 commit into
Draft
Conversation
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
x_searchpreviously authorized anycustom_tool_callwhosecall_idstarted withxs_call-(plus the declaration/destination checks), which allowed a malicious upstream to present an undeclared client tool name (for exampleapply_patch) and bypass the undeclared-tool guard.Description
namesfield toProviderExecutedCallTypeand populate thePROVIDER_EXECUTED_DECLARATION_CALL_TYPESentry forx_searchwith the measured hosted namesx_keyword_search,x_semantic_search, andx_user_search.isAuthorizedProviderExecutedCallto requireitem.nameand to check that the returned name is one of the measured names in addition to matchingitem.typeandcall_idprefix.apply_patchwith a spoofedxs_call-...id is still refused; adjust the relevant test vectors and expectations accordingly.Testing
node_modules/bun/bin/bun.exe test tests/responses-undeclared-tool-guard.test.ts— unit file passed (64 tests, 0 failures).bun run typecheck— typecheck completed successfully.bun run privacy:scan— privacy scan passed.bun run test— full repo test run was not completed to green due to unrelated environment/baseline failures and a Bun runtime mismatch in this environment (an older Bun lackednode:zlib.zstdDecompressSync); the focused unit test for the changed subsystem and typecheck/privacy checks above succeeded using the repository's Bun where applicable.Codex Task