[WRONG BRANCH] fix(claude): withhold ambiguous bare context windows - #332
Draft
luvs01 wants to merge 1 commit into
Draft
[WRONG BRANCH] fix(claude): withhold ambiguous bare context windows#332luvs01 wants to merge 1 commit into
luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
⏳ DRAFT
What to do
Its title has been prefixed with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
buildClaudeContextWindowsallowed rows that were skipped for registration (missing/zero window or Anthropic <1M) to be ignored when deciding whether a bare model ID was ambiguous, which could cause a bare selector to be marked[1m]even though routing might resolve it to a different provider.Description
buildClaudeContextWindowsto count ambiguity over everyroutedModelsrow (not just theregistrablesubset) so any provider that can route the bare id vetoes automatic bare-key registration.registrableset for writing provider-qualified context-window entries and the desktop/native alias registration logic.tests/claude-context-windows.test.tsto assert that bare aliases are withheld when another provider could route the same id even if that provider did not register a positive window, and to verify provider-qualified keys remain present.Testing
./node_modules/.bin/bun test tests/claude-context-windows.test.ts, which passed (16 tests, 0 failures)../node_modules/.bin/bun run typecheckpassed and./node_modules/.bin/bun run privacy:scanpassed../node_modules/.bin/bun run testbut stopped after uncovering unrelated, environment-sensitive failures/timeouts; the change is covered by the focused regression test and the typecheck/privacy scan results.Codex Task