[WRONG BRANCH] fix(responses): honor namespace tool_choice when restoring routed namespace aliases - #327
[WRONG BRANCH] fix(responses): honor namespace tool_choice when restoring routed namespace aliases#327luvs01 wants to merge 1 commit into
Conversation
|
✅ Deterministic PR hygiene checks passed. |
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
tool_choice, allowing a noncanonical upstream to cause restoration of tools the caller did not authorize.Description
authorizedAliaseshelper insrc/responses/namespace-tool-compat.tsthat filters the request-local alias map to only those wire names authorized by the turn'stool_choice.authorizedAliases(plan.aliases, toolChoice)when returning the upstream-rewritten body so downstream restoration only ever sees authorized aliases.tests/namespace-tool-compat.test.tsthat asserts excluded namespace aliases are not armed or restored forallowed_tools, forced selectors, and the"none"case.Testing
bun test tests/namespace-tool-compat.test.tsand it passed.bun run typecheck,bun run test, andbun run privacy:scan, and all completed successfully in the environment used for verification.Codex Task