Repository navigation
fix: do not map positional arguments past '--' - #68
Open
Golopmoui3 wants to merge 1 commit into
Open
Golopmoui3 wants to merge 1 commit into
Golopmoui3 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #57
Problem
Previously, when positional arguments were passed after the double-dash
--delimiter (e.g.,prog build -- abc xyzfor a command defined asbuild [config]),sadegreedily consumed tokens following--into command parameter slots (configbecame'abc', leaving only['xyz']inopts._).According to standard POSIX CLI conventions,
--indicates the end of command options/arguments, and any tokens past--should remain intact inopts._as unparsed operands rather than being shifted into command parameter positions.Solution
raw.indexOf('--').--(post) and available before--(pre = vals._.length - post).<arg>) only against thepreargument pool.[arg]), shift fromvals._only whilepre > 0; otherwise assignundefined(void 0).--remain preserved inopts._.Testing
test/index.jsconfirming:parse(['node', 'cli.js', 'build', '--', 'abc', 'xyz'])producesconfig: undefinedandopts._: ['abc', 'xyz'].parse(['node', 'cli.js', 'build', 'myconf', '--', 'abc', 'xyz'])bindsconfig: 'myconf'and preservesopts._: ['abc', 'xyz'].parse(['node', 'cli.js', 'deploy', 'prod', '--', 'extra'])bindsenv: 'prod'and preservesopts._: ['extra'].test/index.js,test/usage.js,test/utils.js).