Repository navigation
fix: isolate options between parse calls - #67
Open
blueDaydreaming725 wants to merge 1 commit into
Open
blueDaydreaming725 wants to merge 1 commit into
blueDaydreaming725 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing a command currently merges its defaults and aliases into the global options. A later parse of a different command can therefore inherit those options, and a one-off override persists into later calls. Short aliases can also disappear because mri consumes their arrays.
Merge into fresh option objects and copy alias arrays before handing them to mri. The Deno entry gets the same object-isolation fix. This keeps the existing precedence without restoring mutable state after each parse.
Regression tests fail on the original implementation and pass after the fix. The complete Tape suite passes 602 assertions on Node 20.11.1; build and independent CJS/ESM public-entry checks pass. Deno and the oldest supported Node versions were not run.