Repository navigation
Conversation
AI-assisted implementation and verification using OpenAI Codex.
Owner
|
no one does this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registering a command named
constructor,toString,valueOforhasOwnPropertythrowsCommand already existsbefore anything with that name has been registered. The command dictionary inherits these names fromObject.prototype, and its membership check sees them as commands.Give the internal command dictionary a null prototype. Add public registration-and-dispatch regressions for those names, and check that registering an actual duplicate still throws.
Validation: all four registration cases fail on unchanged master.
npm run buildand the complete Tape suite pass, with 602 assertions on Node 14.21.3;git diff --checkpasses. Windows and the Node 6 minimum were not exercised. This clean-master branch excludes the separate help-rendering change. Generated bundles are excluded from the change.AI disclosure: OpenAI Codex assisted with investigation, implementation, regression tests, and this description.