Repository navigation
Conversation
jwoertink
left a comment
jwoertink
left a comment
There was a problem hiding this comment.
There's a few unrelated changes sneaking in here. Let's keep the PR strictly to just documenting the JOIN stuff, and leave all of the ameba changes as they were. Those can be updated in a future PR
| version: ~> 0.10.0 | ||
| ameba: | ||
| github: crystal-ameba/ameba | ||
| version: ~> 1.5.0 |
There was a problem hiding this comment.
This is an unrelated change to the PR. Please revert this change
| - name: Build Ameba | ||
| run: crystal build -o bin/ameba lib/ameba/bin/ameba.cr |
There was a problem hiding this comment.
This is an unrelated change. Let's remove this.
|
done, IIRC, ameba 1.5 will failed, but not related to this PR. I will create a new PR to cherry pick reverted changes. |
|
Should I waiting 有 force merge this PR first and then create a new PR to fix ameba, or do it the other way around? |
|
@zw963 I can't merge this until after the next release, so this PR will be sitting for a while. If you'd like to do a separate PR for the ameba, I would be ok with that. But also not necessary. I'm ok merging this PR as-is when it comes time for that. |
|
Okay, I created #1574，it has already been done before anyway. If consider helpful, you can merge. |
No description provided.