Repository navigation
DM-56143: Minor fixes for lsst.images metadata work - #563
Conversation
This also refactors the special handling of converting reads and adds guards on parameters those conversions don't support.
| if obsInfo.boresight_rotation_coord is not None: | ||
| rotType = RotType.UNKNOWN | ||
| if obsInfo.boresight_rotation_coord == "sky": | ||
| if obsInfo.boresight_rotation_coord.lower() == "sky": |
There was a problem hiding this comment.
How are we getting upper case values? ObservationInfo always generates lower case.
There was a problem hiding this comment.
From VisitInfo writing itself back out to headers: https://github.com/lsst/afw/blob/41b6eb56439ac6a47191309589c181fbfa4659e0/src/image/VisitInfo.cc#L158-L177
There was a problem hiding this comment.
VisitInfoTranslator lower cases that when generating the ObservationInfo.
There was a problem hiding this comment.
It looks like the LSSTCam translator is the outlier that doesn't do that lowercasing. So this is a case where I thought it mattered before (but it didn't, because that translator wasn't getting loaded in the converter task), and it doesn't matter now (because we're explicitly avoiding the per-instrument translators now). And the real fix probably belongs in obs_lsst, though this might still be worth keeping for extra defensiveness.
There was a problem hiding this comment.
It's definitely not harming anything by forcing lower here.
| future_type = VisitImage | ||
| needs_exposure_record = True | ||
|
|
||
| exposure_record = parameters.get("exposure_record") |
There was a problem hiding this comment.
It's a shame we don't put more metadata in the visit record which the Formatter already has access to.
There was a problem hiding this comment.
There are a few places in pipelines (especially AP) where a visit.group would have been particularly useful. Not sure it's worth changing it now, though.
2 participants
Checklist
doc/changes