Skip to content

ci: add release.yml#106

Merged
lsongdev merged 1 commit into
lsongdev:masterfrom
NicTool:ci-updates
May 25, 2026
Merged

ci: add release.yml#106
lsongdev merged 1 commit into
lsongdev:masterfrom
NicTool:ci-updates

Conversation

@msimerson

@msimerson msimerson commented May 25, 2026

Copy link
Copy Markdown
Collaborator

This PR does:

  • ci(release): generate a GitHub release and NPM publish when ALL of the following criteria are met:
    • a PR has merged against master/main
    • the build tests pass
    • the version in package.json has increased

In order for NPM publishing to work, Trusted Publishing has to be set up for the NPM package. @lsongdev, that requires you to make the following edits on the package settings page. The following settings for OIDC / Trusted Publisher need to be:

  • Publisher: Github Actions
  • Org: lsongdev
  • Repository: node-dns
  • Workflow filename: release.yml
  • Allowed actions: Allow npm publish

@msimerson msimerson reopened this May 25, 2026
@msimerson msimerson changed the title ci: add release.yml, update node.js.yml ci: add release.yml May 25, 2026
@msimerson msimerson mentioned this pull request May 25, 2026
@lsongdev lsongdev merged commit ffa45d1 into lsongdev:master May 25, 2026
8 checks passed
@lsongdev

Copy link
Copy Markdown
Owner

I have set it up package publishing on npmjs.

@msimerson msimerson deleted the ci-updates branch May 25, 2026 23:16
@msimerson

Copy link
Copy Markdown
Collaborator Author

thanks! publish is almost automated, but I forgot to set up the NPM publishing step in release.yml. Time to go fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants